Re: [Qemu-devel] [PATCH v2] Add ability to disable build of all targets

[Laurent Desnogues]

On Tue, Sep 11, 2012 at 8:56 PM, Eduardo Habkost <address@hidden> wrote:
> On Mon, Sep 10, 2012 at 06:00:54PM -0500, Anthony Liguori wrote:
>> "Daniel P. Berrange" <address@hidden> writes:
>>
>> > From: "Daniel P. Berrange" <address@hidden>
>> >
>> > Allow passing of '--target-list=' to configure to request that
>> > all targets are to be disabled. This allows for doing a very
>> > fast tools-only build of things like qemu-img, qemu-io, qemu-nbd.
>> >
>> > Signed-off-by: Daniel P. Berrange <address@hidden>
>>
>> Applied. Thanks.
>
> This patch broke the --target-list option:
>
>   $ ./configure --target-list=x86_64-linux-user,x86_64-softmmu
>   [...]
>   ERROR: Target 'x86_64-linux-user,x86_64-softmmu' not recognised
>   $

It also seems to not even allow to use --target-list=.  On my setup
(CentOS 5.6, building in the git directory) the build process just
hangs here:

$ make V=1
cat  | grep =y | sort -u > config-all-devices.mak


Laurent

>>
>> Regards,
>>
>> Anthony Liguori
>>
>> > ---
>> >  configure | 13 ++++---------
>> >  1 file changed, 4 insertions(+), 9 deletions(-)
>> >
>> > diff --git a/configure b/configure
>> > index 75dc9da..472374e 100755
>> > --- a/configure
>> > +++ b/configure
>> > @@ -127,7 +127,7 @@ cc_i386=i386-pc-linux-gnu-gcc
>> >  libs_qga=""
>> >  debug_info="yes"
>> >
>> > -target_list=""
>> > +target_list="DEFAULT"
>> >
>> >  # Default value for a variable defining feature "foo".
>> >  #  * foo="no"  feature will only be used if --enable-foo arg is given
>> > @@ -1319,15 +1319,10 @@ if ! "$python" -c 'import sys; 
>> > sys.exit(sys.version_info < (2,4) or sys.version_
>> >    exit 1
>> >  fi
>> >
>> > -if test -z "$target_list" ; then
>> > -    target_list="$default_target_list"
>> > -else
>> > -    target_list=`echo "$target_list" | sed -e 's/,/ /g'`
>> > -fi
>> > -if test -z "$target_list" ; then
>> > -    echo "No targets enabled"
>> > -    exit 1
>> > +if test "$target_list" = "DEFAULT" ; then
>> > +    target_list=`echo "$default_target_list" | sed -e 's/,/ /g'`
>> >  fi
>> > +
>> >  # see if system emulation was really requested
>> >  case " $target_list " in
>> >    *"-softmmu "*) softmmu=yes
>> > --
>> > 1.7.11.2
>>
>
> --
> Eduardo
>