[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC
From: |
Gerd Hoffmann |
Subject: |
Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC |
Date: |
Mon, 20 Aug 2012 08:07:08 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.6esrpre) Gecko/20120714 Thunderbird/10.0.6 |
Hi,
>>> +#ifndef QXL_HAS_IO_MONITORS_CONFIG_ASYNC
>>> +#define QXL_HAS_IO_MONITORS_CONFIG_ASYNC 0
>>
>> Just delete this and use defined(QXL_HAS_IO_MONITORS_CONFIG_ASYNC).
>
> So you are telling me to undo a change that Gerd asked for - could you
> please at least debate about the merits of both approaches? the point of
> having QXL_HAS_IO_MONITORS_CONFIG_ASYNC always defined was to allow
> usage of #if without defined, which is shorter.
Hmm? That wasn't that I meant, must have been a tyops.
I mean you should just do ...
#ifndef QXL_IO_MONITORS_CONFIG_ASYNC <--- without *_HAS_*
#define QXL_IO_MONITORS_CONFIG_ASYNC $value
#endif
then you don't need QXL_HAS_IO_MONITORS_CONFIG_ASYNC (and all the
#ifdefs) at all ...
cheers,
Gerd
- [Qemu-devel] [PATCH v5 1.2 queue 0/4] QXL_IO_MONITORS_CONFIG_ASYNC + misc, Alon Levy, 2012/08/17
- [Qemu-devel] [PATCH v5 1.2 queue 1/4] qxl/update_area_io: guest_bug on invalid parameters, Alon Levy, 2012/08/17
- [Qemu-devel] [PATCH v5 1.2 queue 2/4] qxl: disallow unknown revisions, Alon Levy, 2012/08/17
- [Qemu-devel] [PATCH v5 1.2 queue 3/4] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC, Alon Levy, 2012/08/17
- [Qemu-devel] [PATCH v6 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC, Alon Levy, 2012/08/17
- [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC, Alon Levy, 2012/08/17
- Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC,
Gerd Hoffmann <=
- Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC, Alon Levy, 2012/08/20
- Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC, Alon Levy, 2012/08/20
- Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC, Gerd Hoffmann, 2012/08/20
- Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC, Alon Levy, 2012/08/20
- Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC, Gerd Hoffmann, 2012/08/20
- Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC, Alon Levy, 2012/08/20
[Qemu-devel] [PATCH v5 1.2 queue 4/4] configure: print spice-protocol and spice-server versions, Alon Levy, 2012/08/17