Re: [Qemu-devel] [PATCH v7 1.2] qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

[Alon Levy]

> > Hi,
> > 
> > >>> +#ifndef QXL_HAS_IO_MONITORS_CONFIG_ASYNC
> > >>> +#define QXL_HAS_IO_MONITORS_CONFIG_ASYNC 0
> > >>
> > >> Just delete this and use
> > >> defined(QXL_HAS_IO_MONITORS_CONFIG_ASYNC).
> > > 
> > > So you are telling me to undo a change that Gerd asked for -
> > > could
> > > you
> > > please at least debate about the merits of both approaches? the
> > > point of
> > > having QXL_HAS_IO_MONITORS_CONFIG_ASYNC always defined was to
> > > allow
> > > usage of #if without defined, which is shorter.
> > 
> > Hmm?  That wasn't that I meant, must have been a tyops.
> > I mean you should just do ...
> > 
> > #ifndef QXL_IO_MONITORS_CONFIG_ASYNC            <--- without
> > *_HAS_*
> > #define QXL_IO_MONITORS_CONFIG_ASYNC $value
> > #endif
> > 
> > then you don't need QXL_HAS_IO_MONITORS_CONFIG_ASYNC (and all the
> > #ifdefs) at all ...
> 
> So you want me to give the io a value - at this point I'd rather just
> add spice-protocol as a submodule, then we don't need to do any of
> this. How about it?

I'm retracting the suggestion, I'll define the missing bits as requested and 
remove the ifdefs to satisfy Blue Swirl.

> 
> > 
> > cheers,
> >   Gerd
> > 
> > 
> > 
> 
>