[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 01/18] smbios: Add a function to directly add an
From: |
Anthony Liguori |
Subject: |
Re: [Qemu-devel] [PATCH 01/18] smbios: Add a function to directly add an entry |
Date: |
Mon, 30 Jul 2012 12:25:16 -0500 |
User-agent: |
Notmuch/0.13.2+93~ged93d79 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) |
Corey Minyard <address@hidden> writes:
> On 07/30/2012 10:37 AM, Anthony Liguori wrote:
>> address@hidden writes:
>>
>>> From: Corey Minyard <address@hidden>
>>>
>>> There was no way to directly add a table entry to the SMBIOS table,
>>> even though the BIOS supports this. So add a function to do this.
>>> This is in preparation for the IPMI handler adding it's SMBIOS table
>>> entry.
>>>
>>> Signed-off-by: Corey Minyard <address@hidden>
>> I don't expect that hardware ever adds SMBIOS entries. Rather, the BIOS
>> adds the entries by probing the hardware.
>
> Well, memory entries are added by QEMU, why not let the BIOS probe for
> that?
QEMU doesn't add any entries by default. SeaBIOS owns SMBIOS. QEMU
uses a backchannel to hand SeaBIOS tables that SeaBIOS can then expose.
The reason we use a table based interface is because type 0 and type 1
tables can have vendor extensions that are in a vendor specific format.
But SeaBIOS unquestionably owns SMBIOS generation.
> Plus, I really doubt that BIOSes on real systems probe for this.
> I'd guess they are hard-coded.
I think you'd be surprised how little is hard coded on modern BIOSes.
>> So I think you should solve this in SeaBIOS, instead of trying to do it
>> in QEMU. I think that also solves the problem you have with
>> pre-firmware init.
>
> The user can pass the I/O base and IRQ values in on the QEMU command
> line, and they can be arbitrary values. The BIOS is not going to be
> able to probe for those.
Then pass the information that the BIOS needs through fw_cfg. That's
what it's there for.
Regards,
Anthony Liguoi
>
> -corey
- Re: [Qemu-devel] [PATCH 10/18] qom: release previous object when setting, (continued)
[Qemu-devel] [PATCH 05/18] qemu-char: Allow a chardev to reconnect if disconnected, minyard, 2012/07/19
[Qemu-devel] [PATCH 11/18] Add a base IPMI interface, minyard, 2012/07/19
[Qemu-devel] [PATCH 03/18] vl: Move init_timer_alarm() earlier, minyard, 2012/07/19
[Qemu-devel] [PATCH 02/18] pc: move SMBIOS setup to after device init, minyard, 2012/07/19
[Qemu-devel] [PATCH 14/18] IPMI: Add a BT low-level interface, minyard, 2012/07/19
[Qemu-devel] [PATCH 18/18] IPMI: Add documentation., minyard, 2012/07/19
[Qemu-devel] [PATCH 12/18] IPMI: Add a PC ISA type structure, minyard, 2012/07/19