Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

[Andreas Färber]

Am 02.07.2012 11:31, schrieb Peter Maydell:
> On 2 July 2012 10:08, Igor Mitsyanko <address@hidden> wrote:
>> So, what's the consensus here, for now new devices go to
>> hw/arm/Makefile.objs while somebody moves all new and old not cpu-specific
>> devices (not just exynos-related) from hw/arm/Makefile.objs to
>> hw/Makefile.objs with one commit? Because having one RTC device compile
>> through hw/Makefile.objs while all other exynos devices are compiled through
>> hw/arm/Makefile.objs doesn't makes much sense.
> 
> I don't want things moved piecemeal, especially not one file from
> a whole board model.
> 
> I'd also like to see a nice clear summary of the ground rules first
> (ie how you decide which makefile / target / whatever a file should
> be in). At the moment I'm not really sure what the rules are, which
> means I can't properly review those bits of patches.

We've been through that like three times lately, not sure what's left to
discuss there?

There's two things to review in the migration we're discussing:
1) Are files compiled before the conversion still compiled afterwards?
2) Does the build break due to use of CPU or explicit swapping?

For new patches you should keep on eye on whether a new device really
must go into hw/arm/Makefile.objs or whether it can go in
hw/Makefile.objs instead. I.e., hw/Makefile.objs (libhwX/) should be the
rule for devices, not the exception. Machines today are tightly coupled
to the CPU and need to go into hw/arch/Makefile.objs always. Whether the
files get placed into hw/arch/ or hw/ is a matter of taste.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg