[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Exynos4: added RTC device
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] Exynos4: added RTC device |
Date: |
Mon, 2 Jul 2012 13:19:57 +0100 |
On 2 July 2012 13:04, Andreas Färber <address@hidden> wrote:
> Am 02.07.2012 11:31, schrieb Peter Maydell:
>> On 2 July 2012 10:08, Igor Mitsyanko <address@hidden> wrote:
>>> So, what's the consensus here, for now new devices go to
>>> hw/arm/Makefile.objs while somebody moves all new and old not cpu-specific
>>> devices (not just exynos-related) from hw/arm/Makefile.objs to
>>> hw/Makefile.objs with one commit? Because having one RTC device compile
>>> through hw/Makefile.objs while all other exynos devices are compiled through
>>> hw/arm/Makefile.objs doesn't makes much sense.
>>
>> I don't want things moved piecemeal, especially not one file from
>> a whole board model.
>>
>> I'd also like to see a nice clear summary of the ground rules first
>> (ie how you decide which makefile / target / whatever a file should
>> be in). At the moment I'm not really sure what the rules are, which
>> means I can't properly review those bits of patches.
>
> We've been through that like three times lately, not sure what's left to
> discuss there?
It's not in docs/ or in some makefile as a comment. I don't mean
"I want another mailing list thread"...
-- PMM
Re: [Qemu-devel] [PATCH] Exynos4: added RTC device, Andreas Färber, 2012/07/02