Re: [Qemu-devel] [PATCH] bitops.h: Add field32() and field64() functions to extract bitfields

[Blue Swirl]

On Tue, Jun 26, 2012 at 6:11 PM, Peter Maydell <address@hidden> wrote:
> On 26 June 2012 18:58, Blue Swirl <address@hidden> wrote:
>> On Mon, Jun 25, 2012 at 7:38 PM, Peter Maydell <address@hidden> wrote:
>>> +static inline uint64_t field64(uint64_t value, int start, int length)
>>
>> start and length could be unsigned.
>
> They could be, but is there any reason why they should be?
> set_bit(), clear_bit() etc use 'int' for bit numbers, so this
> is consistent with that.

Negative shifts don't work, the line with assert() would get shorter
and simpler and I like unsigned values.

>
> -- PMM