[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] bitops.h: Add field32() and field64() functions
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] bitops.h: Add field32() and field64() functions to extract bitfields |
|
Date: |
Tue, 26 Jun 2012 19:11:37 +0100 |
On 26 June 2012 18:58, Blue Swirl <address@hidden> wrote:
> On Mon, Jun 25, 2012 at 7:38 PM, Peter Maydell <address@hidden> wrote:
>> +static inline uint64_t field64(uint64_t value, int start, int length)
>
> start and length could be unsigned.
They could be, but is there any reason why they should be?
set_bit(), clear_bit() etc use 'int' for bit numbers, so this
is consistent with that.
-- PMM
- [Qemu-devel] [PATCH] bitops.h: Add field32() and field64() functions to extract bitfields, Peter Maydell, 2012/06/25
- Re: [Qemu-devel] [PATCH] bitops.h: Add field32() and field64() functions to extract bitfields, malc, 2012/06/25
- Re: [Qemu-devel] [PATCH] bitops.h: Add field32() and field64() functions to extract bitfields, Blue Swirl, 2012/06/26
- Re: [Qemu-devel] [PATCH] bitops.h: Add field32() and field64() functions to extract bitfields,
Peter Maydell <=
- Re: [Qemu-devel] [PATCH] bitops.h: Add field32() and field64() functions to extract bitfields, Blue Swirl, 2012/06/26
- Re: [Qemu-devel] [PATCH] bitops.h: Add field32() and field64() functions to extract bitfields, Peter Maydell, 2012/06/26
- Re: [Qemu-devel] [PATCH] bitops.h: Add field32() and field64() functions to extract bitfields, Blue Swirl, 2012/06/26
- Re: [Qemu-devel] [PATCH] bitops.h: Add field32() and field64() functions to extract bitfields, Markus Armbruster, 2012/06/27
- Re: [Qemu-devel] [PATCH] bitops.h: Add field32() and field64() functions to extract bitfields, Blue Swirl, 2012/06/27
- Re: [Qemu-devel] [PATCH] bitops.h: Add field32() and field64() functions to extract bitfields, Markus Armbruster, 2012/06/28
- Re: [Qemu-devel] [PATCH] bitops.h: Add field32() and field64() functions to extract bitfields, Blue Swirl, 2012/06/28