qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/4] Define and use PRI*PLX format specifier mac


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 0/4] Define and use PRI*PLX format specifier macros for target_phys_addr_t
Date: Mon, 25 Jun 2012 15:54:33 +0100

On 25 June 2012 15:43, Andreas Färber <address@hidden> wrote:
> Am 25.06.2012 16:10, schrieb Peter Maydell:
>> On 25 June 2012 14:48, Andreas Färber <address@hidden> wrote:
>>> Thus I would suggest TARGET_PRIdPHYSADDR, also addressing Eric's
>>> comment. Judging from patches 2-4 it's not used to frequently unlike its
>>> user TARGET_FMT_plx, so we don't have to badly shorten it for usability.
>>
>> The hope is that it is used more extensively in the future (ie
>> any device that would have used TARGET_FMT_plx should use these
>> instead); I think TARGET_PRIdPHYSADDR is too long.
>
> Well, PRI*PHYSADDR would be another option, reasoning:
> target_ | phys_addr | _t --- int_ | least64 | _t (PRI*LEAST64)
> Or maybe PRI*PHYS since int is dropped, too?
>
> Point is, POSIX keeps the part after PRIx readable or at least
> corresponding to the type name

Right. How about TARGET_PRI*PHYS, then?

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]