[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4] Define and use PRI*PLX format specifier mac
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 0/4] Define and use PRI*PLX format specifier macros for target_phys_addr_t |
Date: |
Mon, 25 Jun 2012 15:10:43 +0100 |
On 25 June 2012 14:48, Andreas Färber <address@hidden> wrote:
> Am 25.06.2012 14:45, schrieb Peter Maydell:
>> This patchset defines a set of macros for use in printf format strings
>> for handling target_phys_addr_t values, as suggested by Andreas Färber
>> (http://lists.gnu.org/archive/html/qemu-devel/2012-01/msg01547.html)
>
> What is the X for again? I assume PL = Physical Long, X as in
> hexadecimal would then contradict the d/u and duplicate x/X.
I'm just following the existing use of 'plx' in TARGET_FMT_plx,
but I'm not very attached to the abbreviation.
> Thus I would suggest TARGET_PRIdPHYSADDR, also addressing Eric's
> comment. Judging from patches 2-4 it's not used to frequently unlike its
> user TARGET_FMT_plx, so we don't have to badly shorten it for usability.
The hope is that it is used more extensively in the future (ie
any device that would have used TARGET_FMT_plx should use these
instead); I think TARGET_PRIdPHYSADDR is too long.
-- PMM
- [Qemu-devel] [PATCH 0/4] Define and use PRI*PLX format specifier macros for target_phys_addr_t, Peter Maydell, 2012/06/25
- [Qemu-devel] [PATCH 1/4] targphys.h: Define PRI*PLX format specifier macros, Peter Maydell, 2012/06/25
- [Qemu-devel] [PATCH 4/4] monitor: Use PRI*PLX to avoid TARGET_PHYS_ADDR_BITS ifdef, Peter Maydell, 2012/06/25
- [Qemu-devel] [PATCH 2/4] hw/omap.h: Use PRIxPLX to define OMAP_FMT_plx, Peter Maydell, 2012/06/25
- [Qemu-devel] [PATCH 3/4] hw/sh_serial: Use PRIxPLX rather than %x for physaddr, Peter Maydell, 2012/06/25
- Re: [Qemu-devel] [PATCH 0/4] Define and use PRI*PLX format specifier macros for target_phys_addr_t, Andreas Färber, 2012/06/25
- Re: [Qemu-devel] [PATCH 0/4] Define and use PRI*PLX format specifier macros for target_phys_addr_t,
Peter Maydell <=