[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey |
Date: |
Thu, 24 May 2012 21:51:10 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 |
On 05/24/2012 09:32 PM, Amos Kong wrote:
> Convert 'sendkey' to use. do_sendkey() depends on some variables
> in monitor.c, so reserve qmp_sendkey() to monitor.c
> Rename 'string' to 'keys', rename 'hold_time' to 'hold-time'
>
> Signed-off-by: Amos Kong <address@hidden>
> +##
> +# @sendkey:
> +#
> +# Send keys to VM.
> +#
> +# @keys: key sequence
> +# @hold-time: time to delay key up events
> +#
> +# Returns: Nothing on success
> +# If key is unknown or redundant, QERR_INVALID_PARAMETER
> +# If key is invalid, QERR_INVALID_PARAMETER_VALUE
> +#
> +# Notes: Send @var{keys} to the emulator. @var{keys} could be the name of the
> +# key or the raw value in either decimal or hexadecimal format. Use
> +# @code{-} to press several keys simultaneously.
> +#
> +# Since: 0.14.0
> +##
> +{ 'command': 'sendkey', 'data': {'keys': 'str', '*hold-time': 'int'} }
Rather than making 'keys' a free-form string where qemu then has to
parse '-' to separate keys, should we instead make it a JSON array? For
example,
{ "execute":"sendky", "data":{ "keys":["ctrl", "alt", "del"],
"hold-time":200 } }
--
Eric Blake address@hidden +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 1/3] qerror: add QERR_TOO_MANY_PARAMETERS, Amos Kong, 2012/05/24
- [Qemu-devel] [PATCH 2/3] fix doc of using raw values with sendkey, Amos Kong, 2012/05/24
- [Qemu-devel] [PATCH 3/3] qapi: convert sendkey, Amos Kong, 2012/05/24
- Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey,
Eric Blake <=
- Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey, Amos Kong, 2012/05/25
- Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey, Daniel P. Berrange, 2012/05/25
- Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey, Markus Armbruster, 2012/05/25
- Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey, Luiz Capitulino, 2012/05/25
- Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey, Daniel P. Berrange, 2012/05/25
- Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey, Luiz Capitulino, 2012/05/25
- Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey, Anthony Liguori, 2012/05/25
- Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey, Luiz Capitulino, 2012/05/25
- Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey, Jeff Cody, 2012/05/25
- Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey, Anthony Liguori, 2012/05/25