Re: [Qemu-devel] [PATCH 3/3] qapi: convert sendkey

[Anthony Liguori]

On 05/24/2012 10:51 PM, Eric Blake wrote:
> On 05/24/2012 09:32 PM, Amos Kong wrote:
> > Convert 'sendkey' to use. do_sendkey() depends on some variables
> > in monitor.c, so reserve qmp_sendkey() to monitor.c
> > Rename 'string' to 'keys', rename 'hold_time' to 'hold-time'
> >
> > Signed-off-by: Amos Kong<address@hidden>
>
> > +##
> > +# @sendkey:
> > +#
> > +# Send keys to VM.
> > +#
> > +# @keys: key sequence
> > +# @hold-time: time to delay key up events
> > +#
> > +# Returns: Nothing on success
> > +#          If key is unknown or redundant, QERR_INVALID_PARAMETER
> > +#          If key is invalid, QERR_INVALID_PARAMETER_VALUE
> > +#
> > +# Notes: Send @var{keys} to the emulator. @var{keys} could be the name of the
> > +#        key or the raw value in either decimal or hexadecimal  format. Use
> > +#        @code{-} to press several keys simultaneously.
> > +#
> > +# Since: 0.14.0
> > +##
> > +{ 'command': 'sendkey', 'data': {'keys': 'str', '*hold-time': 'int'} }
>
> Rather than making 'keys' a free-form string where qemu then has to
> parse '-' to separate keys, should we instead make it a JSON array?  For
> example,
>
> { "execute":"sendky", "data":{ "keys":["ctrl", "alt", "del"],
> "hold-time":200 } }

Actually, we should do:

{ 'enum': 'KeyCode',
  'data': [ 'map', 'exclam', 'at', 'numbersign', ...] }

{ 'command': 'sendkey',
  'data': { 'keys': [ 'KeyCode' ], '*hold-time': 'int' } }

That also has the benefit of making it clear what symbolic names of the keycodes 
we support are.

Regards,

Anthony Liguori

>