[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu/configure: fix CFLAGS handling for i386
From: |
Olaf Hering |
Subject: |
Re: [Qemu-devel] [PATCH] qemu/configure: fix CFLAGS handling for i386 |
Date: |
Sat, 31 Mar 2012 18:55:24 +0200 |
User-agent: |
Mutt/1.5.21.rev5543 (2011-12-20) |
On Sat, Mar 31, Peter Maydell wrote:
> On 31 March 2012 16:41, Andreas Färber <address@hidden> wrote:
> > This is the only usage of += outside Makefile fragments, so I wonder if
> > its use may have been by accident. Is it safe in a POSIX context?
> > Or should we better use CFLAGS="$CFLAGS -march=486"?
> > For QEMU_CFLAGS we use the pattern QEMU_CFLAGS="-options $QEMU_CFLAGS"
> > to allow overriding options.
>
> For that matter, should this be setting QEMU_CFLAGS instead of
> CFLAGS? I have to say I'm not entirely sure what the difference
> is...
I havent looked into qemu build internals, but there is most likely a
concept of HOST_TOOLS_CFLAGS and TARGET_CFLAGS in qemus Makefiles.
Olaf