[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 09/36] vmstate: introduce float32 arrays
From: |
Juan Quintela |
Subject: |
Re: [Qemu-devel] [PATCH 09/36] vmstate: introduce float32 arrays |
Date: |
Tue, 20 Mar 2012 16:20:06 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.0.93 (gnu/linux) |
Peter Maydell <address@hidden> wrote:
> On 19 March 2012 22:57, Juan Quintela <address@hidden> wrote:
>> +/* 32 bit float */
>> +
>> +typedef union {
>> + float32 f;
>> + uint32_t i;
>> +} VMStateFloat32;
>> +
>> +static int get_float32(QEMUFile *f, void *pv, size_t size)
>> +{
>> + float32 *v = pv;
>> + VMStateFloat32 u;
>> + qemu_get_be32s(f, &u.i);
>> + *v = u.f;
>> + return 0;
>> +}
>> +
>> +static void put_float32(QEMUFile *f, void *pv, size_t size)
>> +{
>> + float32 *v = pv;
>> + VMStateFloat32 u;
>> + u.f = *v;
>> + qemu_put_be32s(f, &u.i);
>> +}
>
> This conversion (float32<->uint32_t) should be done via
> float32_val() and make_float32().
you are right. we can even simplify things with this. Thanks.
- [Qemu-devel] [PATCH 01/36] vmstate: Simplify test for CPU_SAVE_VERSION, (continued)
- [Qemu-devel] [PATCH 01/36] vmstate: Simplify test for CPU_SAVE_VERSION, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 22/36] vmstate: port mips cpu, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 21/36] mips: bump migration version to 4, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 31/36] vmstate: Add copyright info for cris processor, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 10/36] vmstate: introduce float64 arrays, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 05/36] vmstate: use new style for lm32 cpus, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 28/36] vmstate: rename machine.c to vmstate-cpu.c, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 29/36] vmstate: Add copyright info for alpha processor, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 09/36] vmstate: introduce float32 arrays, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 23/36] arm: save always 32 fpu registers, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 25/36] vmstate: all cpus converted, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 17/36] vmstate: make incompatible change for sparc, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 34/36] vmstate: Add copyright info for mips processor, Juan Quintela, 2012/03/19
- [Qemu-devel] [PATCH 24/36] vmstate: port arm cpu, Juan Quintela, 2012/03/19