[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async
From: |
Avi Kivity |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async |
Date: |
Mon, 05 Mar 2012 20:22:53 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 |
On 03/05/2012 08:16 PM, Anthony Liguori wrote:
>
>>
>>> We're pretty close to being there. Luiz, about how long do you
>>> think before we get there?
>>
>> It's a pity to add new commands along the way.
>
> It's more complicated than this unfortunately.
>
> A client needs to be able to determine whether the 'screendump'
> command works as expected. Unfortunately, when QXL was introduced,
> 'screendump' became broken across multiple releases.
>
> screendump is the right interface, but since it was broken in multiple
> releases, we need another command for a client to determine that it's
> not broken. In the short term, screendump_async is that. After QAPI,
> it will probably be a screendump2.
>
> I don't mind introducing short term commands and then deprecating it
> particularly when they are marked as such.
Zooming out from screendump, there are several ways to deal with broken
commands:
1. introduce new commands
2. introduce capabilities that say "screendump is fixed wrt bug so-and-so"
3. fix it and backport the fix to a stable release
4. ignore the broken command and hope
My preference is 3->2->1->4, or we'll end up with screendump65535 soon.
--
error compiling committee.c: too many arguments to function
- [Qemu-devel] [PATCH v3 0/3] screendump async command, (continued)
- [Qemu-devel] [PATCH v3 0/3] screendump async command, Alon Levy, 2012/03/05
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, Avi Kivity, 2012/03/05
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, Anthony Liguori, 2012/03/05
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, Avi Kivity, 2012/03/05
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, Luiz Capitulino, 2012/03/05
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, Anthony Liguori, 2012/03/05
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async,
Avi Kivity <=
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, Anthony Liguori, 2012/03/05
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, Luiz Capitulino, 2012/03/05
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, Alon Levy, 2012/03/05
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, Avi Kivity, 2012/03/05
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, Alon Levy, 2012/03/05
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, Luiz Capitulino, 2012/03/05
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, Gerd Hoffmann, 2012/03/06
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, Alon Levy, 2012/03/06
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, Alon Levy, 2012/03/06
- Re: [Qemu-devel] [PATCH v2 1/2] console: add hw_screen_dump_async, Gerd Hoffmann, 2012/03/06