Re: [Qemu-devel] [PATCH][v14] megasas: LSI Megaraid SAS HBA emulation

[Anthony Liguori]

On 02/24/2012 10:05 AM, Alexander Graf wrote:
> > > So Alex asked whether I can merge this, which made me
> > > take a look. I don't know much about what this does
> > > so just general comments on all of the code.
> >
> > This should come through Paolo's new SCSI tree.
> >
> > And while I defended this before, I now think it really ought to be split after 
> > trying (and failing) to trim the bits below in Thunderbird.
>
> Split up in what pieces? The only natural split I could think of would be mfi.h 
> and megasas.c.

That would certainly help.

> Splitting megasas.c inside of itself doesn't really make sense, as it's just a 
> new device and useless when not complete.

That doesn't mean that splitting it isn't the right strategy.  But I bet just 
pulling out mfi.h would make it a lot more reasonable to handle.

Regards,

Anthony Liguori