qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/5] boards: rename machine type functions


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH 2/5] boards: rename machine type functions
Date: Fri, 24 Feb 2012 16:12:13 +0000

On 24 February 2012 14:13, Luiz Capitulino <address@hidden> wrote:
> Perform the following renames:
>
>  o qemu_register_machine() -> machine_register()
>  o find_machine() -> machine_find()
>  o find_default_machine()  -> machine_find_default()
>
> Signed-off-by: Luiz Capitulino <address@hidden>
>  52 files changed, 96 insertions(+), 96 deletions(-)

I said I was going to nack the next change-whole-tree
change, so here it is: nack.

At some point we're going to have to actually start
converting boards to be QOM objects themselves, but
(a) I hope we can make that incremental so we can do
things in batches the way we did with MemoryRegion
conversions and (b) until then the qemu_register_machine
rename just looks like unnecessary churn to me.

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]