[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/15] piix: create i8254 through composition
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH 06/15] piix: create i8254 through composition |
Date: |
Tue, 31 Jan 2012 17:04:51 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2012-01-31 15:58, Paolo Bonzini wrote:
> On 01/31/2012 03:51 PM, Jan Kiszka wrote:
>>>>
>>>> BTW, this is yet another benefit of making structures public. You can
>>>> take the
>>>> address of a child and set link fields directly without accessors.
>> Well, that has two sides. We introduced properties to avoid this direct
>> messing.
>>
>> Does linking also work without exposing internals?
>
> Perhaps it doesn't need to expose internals. Just like we create
> interfaces automatically when creating a parent object, perhaps we can
> create children as well, like
>
> TypeInfo type_piix3 = {
> ...
> .children = {
> { "pic[0]", TYPE_I8259, offsetof(PIIX3, pic[0]) },
> { "pic[1]", TYPE_I8259, offsetof(PIIX3, pic[1]) },
> { "pit, TYPE_I8254, offsetof(PIIX3, pit) },
> { "rtc", TYPE_RTC, offsetof(PIIX3, rtc) },
> { }
> }
and .links = ...
Yep, such a thing looks better. I suppose that also opens the door for
(runtime) type checking, right?
> }
>
> QOM's object_init would allocate a single malloced block for all of
> them, carve out space for the parent and all children, and add the
> properties.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
- Re: [Qemu-devel] [PATCH 01/15] pc: merge pc_piix.c into pc.c, (continued)
- [Qemu-devel] [PATCH 06/15] piix: create i8254 through composition, Anthony Liguori, 2012/01/26
- Re: [Qemu-devel] [PATCH 06/15] piix: create i8254 through composition, Jan Kiszka, 2012/01/31
- Re: [Qemu-devel] [PATCH 06/15] piix: create i8254 through composition, Anthony Liguori, 2012/01/31
- Re: [Qemu-devel] [PATCH 06/15] piix: create i8254 through composition, Jan Kiszka, 2012/01/31
- Re: [Qemu-devel] [PATCH 06/15] piix: create i8254 through composition, Anthony Liguori, 2012/01/31
- Re: [Qemu-devel] [PATCH 06/15] piix: create i8254 through composition, Jan Kiszka, 2012/01/31
- Re: [Qemu-devel] [PATCH 06/15] piix: create i8254 through composition, Anthony Liguori, 2012/01/31
- Re: [Qemu-devel] [PATCH 06/15] piix: create i8254 through composition, Jan Kiszka, 2012/01/31
- Re: [Qemu-devel] [PATCH 06/15] piix: create i8254 through composition, Paolo Bonzini, 2012/01/31
- Re: [Qemu-devel] [PATCH 06/15] piix: create i8254 through composition,
Jan Kiszka <=
- Re: [Qemu-devel] [PATCH 06/15] piix: create i8254 through composition, Anthony Liguori, 2012/01/31
- Re: [Qemu-devel] [PATCH 06/15] piix: create i8254 through composition, Jan Kiszka, 2012/01/31
- Re: [Qemu-devel] [PATCH 06/15] piix: create i8254 through composition, Anthony Liguori, 2012/01/31
- Re: [Qemu-devel] [PATCH 06/15] piix: create i8254 through composition, Paolo Bonzini, 2012/01/31
[Qemu-devel] [PATCH 05/15] piix: create the HPET and RTC through composition, Anthony Liguori, 2012/01/26