qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 06/15] piix: create i8254 through composition


From: Jan Kiszka
Subject: Re: [Qemu-devel] [PATCH 06/15] piix: create i8254 through composition
Date: Tue, 31 Jan 2012 15:34:14 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666

On 2012-01-26 20:00, Anthony Liguori wrote:
> @@ -548,6 +550,13 @@ static int piix3_realize(PCIDevice *dev)
>      /* Setup the RTC IRQ */
>      s->rtc.irq = rtc_irq;
>  
> +    /* Realize the PIT */
> +    qdev_set_parent_bus(DEVICE(&s->pit), BUS(s->bus));
> +    qdev_init_nofail(DEVICE(&s->pit));
> +
> +    /* FIXME this should be refactored */
> +    pcspk_init(ISA_DEVICE(&s->pit));

Fixing ATM, ie. converting to qdev/QOM.

Q: How do I use qdev_property_add_link & Co. to establish the relation
from the speaker port device to the PIT?

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux



reply via email to

[Prev in Thread] Current Thread [Next in Thread]