[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 3/6] memory: introduce memory_region_set_alia
From: |
Avi Kivity |
Subject: |
Re: [Qemu-devel] [PATCH v2 3/6] memory: introduce memory_region_set_alias_offset() |
Date: |
Mon, 05 Dec 2011 12:04:34 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20111115 Thunderbird/8.0 |
On 12/04/2011 11:34 PM, Blue Swirl wrote:
> On Sun, Dec 4, 2011 at 18:09, Avi Kivity <address@hidden> wrote:
> > Add an API to update an alias offset of an active alias. This can be
> > used to simplify implementation of dynamic memory banks.
> >
> > */
> > -void memory_region_set_address(MemoryRegion *mr, target_phys_addr_t addr);
> > +void memory_region_set_address(MemoryRegion *mr, target_phys_addr_t
> > offset);
>
> This isn't the function you are looking for, but still 'addr' is
> changed to 'offset'.
>
> > +
> > +/*
> > + * memory_region_set_alias_offset: dynamically update a memory alias's
> > offset
> > + *
> > + * Dynamically updates the offset into the target region that an alias
> > points
> > + * to, as if the fourth argument to memory_region_init_alias() has changed.
> > + *
> > + * @mr: the #MemoryRegion to be updated; should be an alias.
> > + * @offset: the new offset into the target memory region
> > + */
> > +void memory_region_set_alias_offset(MemoryRegion *mr, target_phys_addr_t
> > addr);
>
> Here 'addr' doesn't match the description above.
Thanks, fixed.
--
error compiling committee.c: too many arguments to function
- [Qemu-devel] [PATCH v2 0/6] Memory API mutators, Avi Kivity, 2011/12/04
- [Qemu-devel] [PATCH v2 4/6] memory: optimize empty transactions due to mutators, Avi Kivity, 2011/12/04
- [Qemu-devel] [PATCH v2 2/6] memory: introduce memory_region_set_address(), Avi Kivity, 2011/12/04
- [Qemu-devel] [PATCH v2 6/6] piix_pci: adapt smram mapping to use memory mutators, Avi Kivity, 2011/12/04
- [Qemu-devel] [PATCH v2 3/6] memory: introduce memory_region_set_alias_offset(), Avi Kivity, 2011/12/04
- [Qemu-devel] [PATCH v2 1/6] memory: introduce memory_region_set_enabled(), Avi Kivity, 2011/12/04
- [Qemu-devel] [PATCH v2 5/6] cirrus_vga: adapt to memory mutators API, Avi Kivity, 2011/12/04
- Re: [Qemu-devel] [PATCH v2 0/6] Memory API mutators, Anthony Liguori, 2011/12/07