Re: [Qemu-devel] [RFC][PATCH 02/16] kvm: Move kvmclock into hw/kvm folder

[Andreas Färber]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 03.12.2011 23:33, schrieb Jan Kiszka:
> On 2011-12-03 20:00, Andreas Färber wrote:
>> Am 03.12.2011 12:17, schrieb Jan Kiszka:
>>> diff --git a/hw/kvmclock.c b/hw/kvm/clock.c similarity index
>>> 96% rename from hw/kvmclock.c rename to hw/kvm/clock.c index
>>> 5388bc4..aa37c5d 100644 --- a/hw/kvmclock.c +++
>>> b/hw/kvm/clock.c @@ -11,11 +11,11 @@ * */
>>> 
>>> -#include "qemu-common.h" -#include "sysemu.h" -#include
>>> "sysbus.h" -#include "kvm.h" -#include "kvmclock.h" +#include
>>> <qemu-common.h> +#include <sysemu.h> +#include <kvm.h> 
>>> +#include <hw/sysbus.h> +#include <hw/kvm/clock.h>
>>> 
>>> #include <linux/kvm.h> #include <linux/kvm_para.h>
>> 
>> Please don't start using system includes for everything. Rather
>> extend QEMU_CFLAGS to contain the right user include path(s).
> 
> No problem - and no need to tweak any CFLAGS

Right, I had recursion into kvm/ in mind - would've required -I ../..
to be added to CFLAGS.

> ("" only adds . to the header search paths).

By default that is. -iquote can add further paths. (Unfortunately
didn't solve the Cocoa Block.h vs. block.h problem since Objective-C
frameworks use quotes, too.)

> Do we have a convention that every include in <> is considered
> system header? Should probably be documented then (and code should
> be converted gradually).

The convention I perceived was that everything QEMU was in quotes
whereas POSIX, Linux, zlib, glib, etc. were in angle brackets. Didn't
check for documentation.

Andreas

- -- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.18 (GNU/Linux)

iQIcBAEBAgAGBQJO3KA6AAoJEPou0S0+fgE/izQP/1q0Oje72FdXyUyVxPZw2Ypi
zp+2TFYJ3FJUrTLkkDBjmsaMT0sdIoI/wXxDTrrif9QI1gfRhNlxw9qES+En4xDG
3ClCl6UMNrcq35WrejIvPOXQMvVH6tTnliHBKmG6TSsQXPEFLS/BbWA1Y3gV7nZ4
KXmMHdNqVzmo66AU0FGQPSZyE/u+w8PKnfOIea961tMFtYodny69lzuoBWIaC/oT
8neCRT6U4BVX6hEy6QgY1651IM0KUOUC0fbBwFMwiy+NeL5KgB+GWsrnVq+U0hpM
gDtE09L1IKzuppMLlsx1DmxAZYHX12ZlW5W3np13+qDOkFx+4JqT3AU1MGBDhVQ+
ylbYXAINpcXsV8hTyCv1xoWlCJTUreD5+vVgAe5IN3jJUuXttR867YZHS6w0Xkh2
saTYRdkaywNpb9Jm/8RdP0Nepjq2YKdjP99/Da5/GOlVBOqASycKmtAyKQKerhAx
2n+Os8Ekji9fLM7S1FFWe2i/v/bUiVKb9TPRw98tDaDd9V0RW2AkBrJcL2BlFBC4
nqM57ndpv3phGLbVoin2yo32P6iTqL/bS7iyJap+IeklSzxSyW0bBcJyT0oIZMQ2
TdeZNSS2aF9+SmIp91aNRIWhXDAZGggls5AvrS3FTbyzY0jb4HXLIYVGyLCdzfar
uHBpp0n3XZsqieTYP+f0
=zA/a
-----END PGP SIGNATURE-----