Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

[ronnie sahlberg]

Kevin,

Thanks for the review,
I have attached a modified patch that addresses all your comments.
Please review and/or apply.


> I doubt that you really need sysemu.h. If you did, I think you couldn't 
> successfully build qemu-img and qemu-io.

You are right. I removed it.

> Is acb->status == -ECANCELED redundant with acb->canceled == 1?

Fixed.

> qemu_aio_get() never returns NULL, so this check is unnecessary.

Done.

> I think you should also set bs->total_sectors.

Done.

> iscsi_destroy_url() is only ever called here. Do we leak it in the normal 
> path?

It didnt leak but the the label was confusing. I have changed it from
"failed" to "finished" since this part
is executed for both normal and failures.



Thanks
Ronnie Sahlberg

0001-This-provides-built-in-support-for-iSCSI-to-QEMU.patch
Description: Text Data

0001-This-provides-built-in-support-for-iSCSI-to-QEMU.patch.gz
Description: GNU Zip compressed data