Re: [Qemu-devel] [PATCH] This patch adds a new block driver : iSCSI

[ronnie sahlberg]

Previous version of the patch received very positive feedback and
several expressed seeing positive value of a built-in initiator.
I updated patch from feedback 3 weeks ago and Stefan kindly reviewed it.


Is there some other problem with the patch I am not aware of that I
should address?

I have been trying to push this patch in different versions since
December last year.
There is obviously a problem here I am not aware of.
Please advice what the problem is and I will try to rectify it.


Please advice on how I can move forward. I feel a bit at roads end
here. Please help.


regards
ronnie sahlberg



On Mon, Oct 10, 2011 at 7:46 AM, ronnie sahlberg
<address@hidden> wrote:
> ping?
>
>
> On Thu, Sep 29, 2011 at 4:54 PM, Stefan Hajnoczi
> <address@hidden> wrote:
>> On Wed, Sep 21, 2011 at 07:37:55PM +1000, Ronnie Sahlberg wrote:
>>> This provides built-in support for iSCSI to QEMU.
>>> This has the advantage that the iSCSI devices need not be made visible to 
>>> the host, which is useful if you have very many virtual machines and very 
>>> many iscsi devices.
>>> It also has the benefit that non-root users of QEMU can access iSCSI 
>>> devices across the network without requiring root privilege on the host.
>>>
>>> This driver interfaces with the multiplatform posix library for iscsi 
>>> initiator/client access to iscsi devices hosted at
>>>     git://github.com/sahlberg/libiscsi.git
>>>
>>> The patch adds the driver to interface with the iscsi library.
>>> It also updated the configure script to
>>> * by default, probe is libiscsi is available and if so, build
>>>   qemu against libiscsi.
>>> * --enable-libiscsi
>>>   Force a build against libiscsi. If libiscsi is not available
>>>   the build will fail.
>>> * --disable-libiscsi
>>>   Do not link against libiscsi, even if it is available.
>>>
>>> When linked with libiscsi, qemu gains support to access iscsi resources 
>>> such as disks and cdrom directly, without having to make the devices 
>>> visible to the host.
>>>
>>> You can specify devices using a iscsi url of the form :
>>> iscsi://[<username>[:<password>@]]<host>[:<port]/<target-iqn-name>/<lun>
>>> When using authentication, the password can optionally be set with
>>> LIBISCSI_CHAP_PASSWORD="password" to avoid it showing up in the process list
>>>
>>> Signed-off-by: Ronnie Sahlberg <address@hidden>
>>> ---
>>>  Makefile.objs |    1 +
>>>  block/iscsi.c |  596 
>>> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>  configure     |   31 +++
>>>  trace-events  |    7 +
>>>  4 files changed, 635 insertions(+), 0 deletions(-)
>>>  create mode 100644 block/iscsi.c
>>
>> Reviewed-by: Stefan Hajnoczi <address@hidden>
>>
>