Re: [Qemu-devel] [PATCH v2 04/23] memory: merge adjacent segments of a single memory region

[Paolo Bonzini]

On 07/26/2011 01:38 PM, Avi Kivity wrote:
> > if (j != i) {
> >
> > > +        memmove(&view->ranges[i], &view->ranges[j],
> > > +                (view->nr - j) * sizeof(view->ranges[j]));
> > > +        view->nr -= j - i;
> > > +    }
> >
> > }
>
> Seems to work both ways?

Sure, but you're pointlessly memmove-ing memory over itself.  I'm not 
sure how many segments a single memory region will usually have, but 
it's better to be safe.

Paolo