qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 04/23] memory: merge adjacent segments of a s


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH v2 04/23] memory: merge adjacent segments of a single memory region
Date: Tue, 26 Jul 2011 08:41:42 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20110707 Thunderbird/5.0

On 07/26/2011 04:36 AM, Paolo Bonzini wrote:
> On 07/26/2011 01:26 PM, Avi Kivity wrote:
>> +    while (i < view->nr) {
>> +        j = i + 1;
>> +        while (j < view->nr
>> +               && can_merge(&view->ranges[j-1], &view->ranges[j])) {
>> +            view->ranges[i].addr.size += view->ranges[j].addr.size;
>> +            ++j;
>> +        }
>> +        ++i;
> 
> if (j != i) {
> 
>> +        memmove(&view->ranges[i], &view->ranges[j],
>> +                (view->nr - j) * sizeof(view->ranges[j]));
>> +        view->nr -= j - i;
>> +    }
> 
> }

Err, j = i + 1, and increments.  Your conditional will always be true.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]