[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 04/23] memory: merge adjacent segments of a s
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v2 04/23] memory: merge adjacent segments of a single memory region |
Date: |
Tue, 26 Jul 2011 08:41:42 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20110707 Thunderbird/5.0 |
On 07/26/2011 04:36 AM, Paolo Bonzini wrote:
> On 07/26/2011 01:26 PM, Avi Kivity wrote:
>> + while (i < view->nr) {
>> + j = i + 1;
>> + while (j < view->nr
>> + && can_merge(&view->ranges[j-1], &view->ranges[j])) {
>> + view->ranges[i].addr.size += view->ranges[j].addr.size;
>> + ++j;
>> + }
>> + ++i;
>
> if (j != i) {
>
>> + memmove(&view->ranges[i], &view->ranges[j],
>> + (view->nr - j) * sizeof(view->ranges[j]));
>> + view->nr -= j - i;
>> + }
>
> }
Err, j = i + 1, and increments. Your conditional will always be true.
r~
[Qemu-devel] [PATCH v2 03/23] memory: implement dirty tracking, Avi Kivity, 2011/07/26
[Qemu-devel] [PATCH v2 10/23] memory: add backward compatibility for old portio registration, Avi Kivity, 2011/07/26
[Qemu-devel] [PATCH v2 17/23] pc: grab system_memory, Avi Kivity, 2011/07/26
[Qemu-devel] [PATCH v2 08/23] memory: late initialization of ram_addr, Avi Kivity, 2011/07/26
[Qemu-devel] [PATCH v2 11/23] memory: add backward compatibility for old mmio registration, Avi Kivity, 2011/07/26
[Qemu-devel] [PATCH v2 13/23] memory: separate building the final memory map into two steps, Avi Kivity, 2011/07/26
[Qemu-devel] [PATCH v2 06/23] memory: abstract address space operations, Avi Kivity, 2011/07/26
[Qemu-devel] [PATCH v2 14/23] memory: transaction API, Avi Kivity, 2011/07/26
[Qemu-devel] [PATCH v2 09/23] memory: I/O address space support, Avi Kivity, 2011/07/26