Re: [Qemu-devel] [PATCH RESEND 1/3] xen: Add the Xen platform pci device

[Michael S. Tsirkin]

On Thu, Jun 16, 2011 at 05:05:17PM +0100, address@hidden wrote:
> diff --git a/hw/pci_ids.h b/hw/pci_ids.h
> index d9457ed..d94578c 100644
> --- a/hw/pci_ids.h
> +++ b/hw/pci_ids.h
> @@ -109,3 +109,5 @@
>  #define PCI_DEVICE_ID_INTEL_82371AB      0x7111
>  #define PCI_DEVICE_ID_INTEL_82371AB_2    0x7112
>  #define PCI_DEVICE_ID_INTEL_82371AB_3    0x7113
> +
> +#define PCI_VENDOR_ID_XENSOURCE          0x5853

Please stick to names in  include/linux/pci_ids.h
in the linux tree.

$ grep XEN /scm/linux-2.6/include/linux/pci_ids.h 
#define PCI_VENDOR_ID_NETXEN            0x4040
#define PCI_VENDOR_ID_XEN               0x5853
#define PCI_DEVICE_ID_XEN_PLATFORM      0x0001



> diff --git a/hw/xen_platform.c b/hw/xen_platform.c
> new file mode 100644
> index 0000000..b167eee

...

> +
> +    pci_config_set_vendor_id(pci_conf, PCI_VENDOR_ID_XENSOURCE);
> +    pci_config_set_device_id(pci_conf, 0x0001);

PCI_DEVICE_ID_XEN_PLATFORM

> +    pci_set_word(pci_conf + PCI_SUBSYSTEM_VENDOR_ID, 
> PCI_VENDOR_ID_XENSOURCE);
> +    pci_set_word(pci_conf + PCI_SUBSYSTEM_ID, 0x0001);

Same.