[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Xen-devel] [PATCH 3/3] xen: implement unplug protocol
From: |
Stefano Stabellini |
Subject: |
Re: [Qemu-devel] [Xen-devel] [PATCH 3/3] xen: implement unplug protocol in xen_platform |
Date: |
Thu, 23 Jun 2011 14:11:52 +0100 |
User-agent: |
Alpine 2.00 (DEB 1167 2008-08-23) |
On Fri, 17 Jun 2011, Anthony PERARD wrote:
> > +static void unplug_nic(PCIBus *b, PCIDevice *d)
> > +{
> > + if (d->config[0xa] == 0 && d->config[0xb] == 2) {
>
> You should use:
> pci_get_word(d->config+PCI_CLASS_DEVICE) == PCI_CLASS_NETWORK_ETHERNET
>
> It'll be clearer.
>
thanks, I'll do that
> > +static void unplug_disks(PCIBus *b, PCIDevice *d)
> > +{
> > + if (d->config[0xa] == 1 && d->config[0xb] == 1) {
>
> Same here with PCI_CLASS_STORAGE_IDE.
>
OK
- [Qemu-devel] [PATCH 0/3] xen: support PV on HVM guests, Stefano Stabellini, 2011/06/16
- [Qemu-devel] [PATCH 3/3] xen: implement unplug protocol in xen_platform, stefano.stabellini, 2011/06/16
- Re: [Qemu-devel] [Xen-devel] [PATCH 3/3] xen: implement unplug protocol in xen_platform, Anthony PERARD, 2011/06/17
- Re: [Qemu-devel] [Xen-devel] [PATCH 3/3] xen: implement unplug protocol in xen_platform,
Stefano Stabellini <=
- Re: [Qemu-devel] [PATCH 3/3] xen: implement unplug protocol in xen_platform, Michael S. Tsirkin, 2011/06/20
- Message not available
- Re: [Qemu-devel] [PATCH 3/3] xen: implement unplug protocol in xen_platform, Kevin Wolf, 2011/06/20
- Re: [Qemu-devel] [PATCH 3/3] xen: implement unplug protocol in xen_platform, Stefano Stabellini, 2011/06/23
- Re: [Qemu-devel] [PATCH 3/3] xen: implement unplug protocol in xen_platform, Kevin Wolf, 2011/06/27
- Re: [Qemu-devel] [PATCH 3/3] xen: implement unplug protocol in xen_platform, Stefano Stabellini, 2011/06/27
- Re: [Qemu-devel] [PATCH 3/3] xen: implement unplug protocol in xen_platform, Kevin Wolf, 2011/06/27
- Re: [Qemu-devel] [PATCH 3/3] xen: implement unplug protocol in xen_platform, Stefano Stabellini, 2011/06/28
[Qemu-devel] [PATCH RESEND 1/3] xen: Add the Xen platform pci device, stefano.stabellini, 2011/06/16
[Qemu-devel] [PATCH 2/3] pci: export pci_unplug_device, stefano.stabellini, 2011/06/16