Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure

[Markus Armbruster]

Aurelien Jarno <address@hidden> writes:

> On Fri, Apr 29, 2011 at 05:59:19PM +0200, Marc-Antoine Perennou wrote:
>> pulse/simple.h does not include stdlib.h
>> We cannot use NULL since it may not be defined
>> Use 0 instead
>
> I am unable to reproduce this issue, even with gcc-4.6. Also please note
> that NULL is defined in <stddef.h>, not <stdlib.h>.

NULL is defined in stddef.h (ISO/IEC 9899:1999 7.17), locale.h (ibid
7.11), stdio.h (ibid 7.19.1), stdlib.h (ibid 7.20), string.h (ibid
7.21.1), time.h (ibid 7.23.1), wchar.h (ibid 7.24.1).

>                                                     <stddef.h> is 
> included from <sys/types.h> which is included from <pulse/simple.h>.

I don't think POSIX specifies sys/types.h defines NULL, let alone
includes stddef.h.

> Do you have more information about the issue.
>
>> Signed-off-by: Marc-Antoine Perennou <address@hidden>
>> ---
>>  configure |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>> 
>> diff --git a/configure b/configure
>> index ea8b676..d67c3ce 100755
>> --- a/configure
>> +++ b/configure
>> @@ -1567,7 +1567,7 @@ for drv in $audio_drv_list; do
>> 
>>      pa)
>>      audio_drv_probe $drv pulse/simple.h "-lpulse-simple -lpulse" \
>> -        "pa_simple *s = NULL; pa_simple_free(s); return 0;"
>> +        "pa_simple *s = 0; pa_simple_free(s); return 0;"
>
> It should be ((void*)0) instead of simply 0.

Matter of taste.

>>      libs_softmmu="-lpulse -lpulse-simple $libs_softmmu"
>>      audio_pt_int="yes"
>>      ;;