[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure |
Date: |
Fri, 3 Jun 2011 22:33:10 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, Apr 29, 2011 at 05:59:19PM +0200, Marc-Antoine Perennou wrote:
> pulse/simple.h does not include stdlib.h
> We cannot use NULL since it may not be defined
> Use 0 instead
I am unable to reproduce this issue, even with gcc-4.6. Also please note
that NULL is defined in <stddef.h>, not <stdlib.h>. <stddef.h> is
included from <sys/types.h> which is included from <pulse/simple.h>.
Do you have more information about the issue.
> Signed-off-by: Marc-Antoine Perennou <address@hidden>
> ---
> configure | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/configure b/configure
> index ea8b676..d67c3ce 100755
> --- a/configure
> +++ b/configure
> @@ -1567,7 +1567,7 @@ for drv in $audio_drv_list; do
>
> pa)
> audio_drv_probe $drv pulse/simple.h "-lpulse-simple -lpulse" \
> - "pa_simple *s = NULL; pa_simple_free(s); return 0;"
> + "pa_simple *s = 0; pa_simple_free(s); return 0;"
It should be ((void*)0) instead of simply 0.
> libs_softmmu="-lpulse -lpulse-simple $libs_softmmu"
> audio_pt_int="yes"
> ;;
> --
> 1.7.5.52.ge839f.dirty
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
- Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure,
Aurelien Jarno <=
- Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure, malc, 2011/06/03
- Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure, Aurelien Jarno, 2011/06/03
- Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure, malc, 2011/06/03
- Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure, Marc-Antoine Perennou, 2011/06/09
- Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure, Andreas Färber, 2011/06/09
- Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure, Peter Maydell, 2011/06/09
- Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure, Markus Armbruster, 2011/06/10
- Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure, Marc-Antoine Perennou, 2011/06/24
- Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure, Stefan Hajnoczi, 2011/06/24
Re: [Qemu-devel] [PATCH] qemu-kvm: fix pulseaudio detection in configure, Markus Armbruster, 2011/06/09