[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] Import Linux headers for KVM and vhost
From: |
Jan Kiszka |
Subject: |
Re: [Qemu-devel] [PATCH v2] Import Linux headers for KVM and vhost |
Date: |
Wed, 04 May 2011 12:28:32 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 |
On 2011-05-03 22:22, Peter Maydell wrote:
> On 3 May 2011 17:48, Jan Kiszka <address@hidden> wrote:
>> +++ b/scripts/update-linux-headers.sh
>> @@ -0,0 +1,47 @@
>> +#!/bin/sh
>
> No -e ?
>
>> +rm -rf $output/include/linux/*
>
> Given that updating the kernel headers will blow away large
> subsets of include/ like this, maybe we should use a less generic
> name than "include", so it's clear that it's just a set of
> automatically maintained and updated files, rather than
> a good place to put random QEMU header files?
>
> kernel-headers/ seems like an obvious choice.
>
> Is it worth having a README in the directory saying "don't
> edit these, they are copies of the kernel headers, they can
> be updated with <whatever>", or is that unnecessary?
>
No, these suggestion all make sense. I've incorporated them.
Thanks,
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
- Re: [Qemu-devel] [PATCH v2] Import Linux headers for KVM and vhost, (continued)
- Re: [Qemu-devel] [PATCH v2] Import Linux headers for KVM and vhost, Peter Maydell, 2011/05/03
- Re: [Qemu-devel] [PATCH v2] Import Linux headers for KVM and vhost, Jan Kiszka, 2011/05/03
- Re: [Qemu-devel] [PATCH v2] Import Linux headers for KVM and vhost, Anthony Liguori, 2011/05/03
- Re: [Qemu-devel] [PATCH v2] Import Linux headers for KVM and vhost, Jan Kiszka, 2011/05/03
- Re: [Qemu-devel] [PATCH v2] Import Linux headers for KVM and vhost, Anthony Liguori, 2011/05/03
- Re: [Qemu-devel] [PATCH v2] Import Linux headers for KVM and vhost, Michael S. Tsirkin, 2011/05/03
- Re: [Qemu-devel] [PATCH v2] Import Linux headers for KVM and vhost, Jan Kiszka, 2011/05/04
- Re: [Qemu-devel] [PATCH v2] Import Linux headers for KVM and vhost, Rusty Russell, 2011/05/09
Re: [Qemu-devel] [PATCH v2] Import Linux headers for KVM and vhost, Peter Maydell, 2011/05/03