qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2] Import Linux headers for KVM and vhost


From: Peter Maydell
Subject: Re: [Qemu-devel] [PATCH v2] Import Linux headers for KVM and vhost
Date: Tue, 3 May 2011 21:22:12 +0100

On 3 May 2011 17:48, Jan Kiszka <address@hidden> wrote:
> +++ b/scripts/update-linux-headers.sh
> @@ -0,0 +1,47 @@
> +#!/bin/sh

No -e ?

> +rm -rf $output/include/linux/*

Given that updating the kernel headers will blow away large
subsets of include/ like this, maybe we should use a less generic
name than "include", so it's clear that it's just a set of
automatically maintained and updated files, rather than
a good place to put random QEMU header files?

kernel-headers/ seems like an obvious choice.

Is it worth having a README in the directory saying "don't
edit these, they are copies of the kernel headers, they can
be updated with <whatever>", or is that unnecessary?

-- PMM



reply via email to

[Prev in Thread] Current Thread [Next in Thread]