qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC][PATCH v2 15/17] guest agent: qemu-ga daemon

From: Michael Roth
Subject: Re: [Qemu-devel] [RFC][PATCH v2 15/17] guest agent: qemu-ga daemon
Date: Thu, 21 Apr 2011 08:21:33 -0500
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.2.15) Gecko/20110303 Thunderbird/3.1.9 
On 04/21/2011 03:50 AM, Jes Sorensen wrote:

On 04/18/11 17:02, Michael Roth wrote:

+static const char *ga_log_level_str(GLogLevelFlags level)
+{
+    switch (level&  G_LOG_LEVEL_MASK) {
+        case G_LOG_LEVEL_ERROR:     return "error";
+        case G_LOG_LEVEL_CRITICAL:  return "critical";
+        case G_LOG_LEVEL_WARNING:   return "warning";
+        case G_LOG_LEVEL_MESSAGE:   return "message";
+        case G_LOG_LEVEL_INFO:      return "info";
+        case G_LOG_LEVEL_DEBUG:     return "debug";
+        default:                    return "user";
+    }


Urgh!

No two statements on the same line please!
Darn, I was hoping my surplus on coding style points for actually indenting my case statements would make up for that :) 



Jes
reply via email to
[Prev in Thread] Current Thread [Next in Thread]