qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [RFC][PATCH v2 08/17] qapi: fix Error usage in qemu-soc


From: Jes Sorensen
Subject: Re: [Qemu-devel] [RFC][PATCH v2 08/17] qapi: fix Error usage in qemu-sockets.c
Date: Thu, 21 Apr 2011 10:20:45 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.15) Gecko/20110307 Fedora/3.1.9-0.39.b3pre.fc14 Thunderbird/3.1.9

On 04/18/11 17:02, Michael Roth wrote:
> Fix spurious errors due to not initializing Error pointer to NULL before
> checking for errors.
> 
> Signed-off-by: Michael Roth <address@hidden>
> ---
>  qemu-sockets.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/qemu-sockets.c b/qemu-sockets.c
> index dc8beeb..e709e5f 100644
> --- a/qemu-sockets.c
> +++ b/qemu-sockets.c
> @@ -630,7 +630,7 @@ int unix_connect(const char *path)
>  {
>      QemuOpts *opts;
>      int sock;
> -    Error *err;
> +    Error *err = NULL;
>  
>      opts = qemu_opts_create(&dummy_opts, NULL, 0, &err);
>      if (err) {

This one really should go into the tree asap, even if the rest of the
virt agent patches are still pending.

Reviewed-by: Jes Sorensen <address@hidden>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]