[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: [PATCH v4 0/4] strtosz() cleanups
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] Re: [PATCH v4 0/4] strtosz() cleanups |
|
Date: |
Tue, 25 Jan 2011 11:14:28 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) |
Jes Sorensen <address@hidden> writes:
> On 01/24/11 18:28, Stefan Weil wrote:
>> There was some discussion regarding this patch set.
>> I agree with Markus that part of the first patch
>> should be removed: don't change char to unsigned char.
>
> The unsigned char should definitely go in, leaving it as a signed char
> doesn't serve any purpose.
Leaving something as is doesn't need justification. Changing it does.
The justification presented so far was "it is prettier to match the real
behavior of pure toupper()". Which I don't buy. But without commit
access, I'm not a buyer.
[...]
- Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement, (continued)
- Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement, Markus Armbruster, 2011/01/24
- Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement, Jes Sorensen, 2011/01/24
- Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement, Markus Armbruster, 2011/01/24
- Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement, Jes Sorensen, 2011/01/25
- Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement, Markus Armbruster, 2011/01/25
- Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement, Jes Sorensen, 2011/01/25
[Qemu-devel] [PATCH 3/4] strtosz(): Fix name confusion in use of modf(), Jes . Sorensen, 2011/01/24
[Qemu-devel] Re: [PATCH v4 0/4] strtosz() cleanups, Kevin Wolf, 2011/01/24