[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() st
From: |
Jes Sorensen |
Subject: |
Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement |
Date: |
Tue, 25 Jan 2011 10:19:26 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13) Gecko/20101209 Fedora/3.1.7-0.35.b3pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.7 |
On 01/24/11 18:47, Markus Armbruster wrote:
> Jes Sorensen <address@hidden> writes:
>>>>> qemu_toupper() - whats the problem?
>>> If a STRTOSZ_DEFSUFFIX_T? expands to a lower case character, its case
>>> will not match any input.
>>
>> Right, so one has to be careful when adding new suffix constants.
>
> Calls for a comment right next to the definition of the
> STRTOSZ_DEFSUFFIX_T*.
>
> I hate unstated restrictions that are hidden far away from the place
> where you can break them.
Well I am fine with a comment in the code.
>> However given that we already have all the likely to be used ones for
>> the near future, that isn't exactly a big issue.
>>
>> On the other hand forcing the use of the macros makes it less likely
>> that someone specifies an unsupported constant by hitting 'y' instead of
>> 't' or similar.
>
> Takes a combination of butterfingers, cross-eyedness, and near-total
> incompetence at basic smoke-testing.
Not really, all it takes is someone writing a piece of code, not
thinking about it, therefore only testing things where a suffix is
specified as an argument and it gets missed.
Jes
- Re: [Qemu-devel] [PATCH 1/4] strtosz(): use unsigned char and switch to qemu_isspace(), (continued)
[Qemu-devel] [PATCH 2/4] strtosz() use qemu_toupper() to simplify switch statement, Jes . Sorensen, 2011/01/24
[Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement, Jes . Sorensen, 2011/01/24
- Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement, Markus Armbruster, 2011/01/24
- Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement, Jes Sorensen, 2011/01/24
- Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement, Markus Armbruster, 2011/01/24
- Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement, Jes Sorensen, 2011/01/24
- Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement, Markus Armbruster, 2011/01/24
- Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement,
Jes Sorensen <=
- Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement, Markus Armbruster, 2011/01/25
- Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement, Jes Sorensen, 2011/01/25
[Qemu-devel] [PATCH 3/4] strtosz(): Fix name confusion in use of modf(), Jes . Sorensen, 2011/01/24
[Qemu-devel] Re: [PATCH v4 0/4] strtosz() cleanups, Kevin Wolf, 2011/01/24