[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/8] target-arm: Translate with VFP len/stride f
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH 4/8] target-arm: Translate with VFP len/stride from TB flags, not CPUState |
Date: |
Wed, 12 Jan 2011 11:21:50 +0100 |
User-agent: |
Mutt/1.5.18 (2008-05-17) |
On Tue, Jan 11, 2011 at 10:12:14PM +0000, Peter Maydell wrote:
> When translating, the VFP vector length and stride for this TB are encoded
> in the TB flags; the CPUState copies may be different and must not be used.
>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> target-arm/translate.c | 10 +++++++---
> 1 files changed, 7 insertions(+), 3 deletions(-)
Reviewed-by: Aurelien Jarno <address@hidden>
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index 9e0b0b1..624a443 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -60,6 +60,8 @@ typedef struct DisasContext {
> int user;
> #endif
> int vfp_enabled;
> + int vec_len;
> + int vec_stride;
> } DisasContext;
>
> #if defined(CONFIG_USER_ONLY)
> @@ -2895,7 +2897,7 @@ static int disas_vfp_insn(CPUState * env, DisasContext
> *s, uint32_t insn)
> rm = VFP_SREG_M(insn);
> }
>
> - veclen = env->vfp.vec_len;
> + veclen = s->vec_len;
> if (op == 15 && rn > 3)
> veclen = 0;
>
> @@ -2916,9 +2918,9 @@ static int disas_vfp_insn(CPUState * env, DisasContext
> *s, uint32_t insn)
> veclen = 0;
> } else {
> if (dp)
> - delta_d = (env->vfp.vec_stride >> 1) + 1;
> + delta_d = (s->vec_stride >> 1) + 1;
> else
> - delta_d = env->vfp.vec_stride + 1;
> + delta_d = s->vec_stride + 1;
>
> if ((rm & bank_mask) == 0) {
> /* mixed scalar/vector */
> @@ -9083,6 +9085,8 @@ static inline void
> gen_intermediate_code_internal(CPUState *env,
> }
> #endif
> dc->vfp_enabled = ARM_TBFLAG_VFPEN(tb->flags);
> + dc->vec_len = ARM_TBFLAG_VECLEN(tb->flags);
> + dc->vec_stride = ARM_TBFLAG_VECSTRIDE(tb->flags);
> cpu_F0s = tcg_temp_new_i32();
> cpu_F1s = tcg_temp_new_i32();
> cpu_F0d = tcg_temp_new_i64();
> --
> 1.6.3.3
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
- [Qemu-devel] [PATCH v2 0/8] target-arm: Translate based on TB flags, not CPUState, Peter Maydell, 2011/01/11
- [Qemu-devel] [PATCH 4/8] target-arm: Translate with VFP len/stride from TB flags, not CPUState, Peter Maydell, 2011/01/11
- Re: [Qemu-devel] [PATCH 4/8] target-arm: Translate with VFP len/stride from TB flags, not CPUState,
Aurelien Jarno <=
- [Qemu-devel] [PATCH 3/8] target-arm: Translate with VFP-enabled from TB flags, not CPUState, Peter Maydell, 2011/01/11
- [Qemu-devel] [PATCH 7/8] target-arm: Set privileged bit in TB flags correctly for M profile, Peter Maydell, 2011/01/11
- [Qemu-devel] [PATCH 5/8] target-arm: Translate with Thumb state from TB flags, not CPUState, Peter Maydell, 2011/01/11
- [Qemu-devel] [PATCH 1/8] target-arm: Don't generate code specific to current CPU mode for SRS, Peter Maydell, 2011/01/11
- [Qemu-devel] [PATCH 2/8] target-arm: Add symbolic constants for bitfields in TB flags, Peter Maydell, 2011/01/11