[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 4/7] Make error handling more consistent in img_
|
From: |
Jes Sorensen |
|
Subject: |
[Qemu-devel] Re: [PATCH 4/7] Make error handling more consistent in img_create() and img_resize() |
|
Date: |
Mon, 06 Dec 2010 16:32:56 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.12) Gecko/20101103 Fedora/1.0-0.33.b2pre.fc14 Lightning/1.0b3pre Thunderbird/3.1.6 |
On 12/06/10 16:25, Kevin Wolf wrote:
>> }
>> n = get_option_parameter(param, BLOCK_OPT_SIZE)->value.n;
>> free_option_parameters(param);
>>
>> bs = bdrv_new_open(filename, fmt, BDRV_O_FLAGS | BDRV_O_RDWR);
>> if (!bs) {
>> - return 1;
>> + ret = -1;
>> + goto out;
>> }
>
> Same here.
>
> Heh, wanted to try it out to be sure, but the compiler notices that, so
> it doesn't even build:
Grrrrr I am an idiot!
Sorry about the noise, I was sure I had tested that last change. Fix
coming up in a few minutes.
Cheers,
Jes
- [Qemu-devel] [PATCH v3 0/7] Cleanup qemu-img code, Jes . Sorensen, 2010/12/06
- [Qemu-devel] [PATCH 2/7] Use qemu_mallocz() instead of calloc() in img_convert(), Jes . Sorensen, 2010/12/06
- [Qemu-devel] [PATCH 5/7] Consolidate printing of block driver options, Jes . Sorensen, 2010/12/06
- [Qemu-devel] [PATCH 4/7] Make error handling more consistent in img_create() and img_resize(), Jes . Sorensen, 2010/12/06
- [Qemu-devel] [PATCH 6/7] Fix formatting and missing braces in qemu-img.c, Jes . Sorensen, 2010/12/06
- [Qemu-devel] [PATCH 1/7] Add missing tracing to qemu_mallocz(), Jes . Sorensen, 2010/12/06
- [Qemu-devel] [PATCH 7/7] Fail if detecting an unknown option, Jes . Sorensen, 2010/12/06
- [Qemu-devel] [PATCH 3/7] img_convert(): Only try to free bs[] entries if bs is valid., Jes . Sorensen, 2010/12/06
- [Qemu-devel] Re: [PATCH v3 0/7] Cleanup qemu-img code, Kevin Wolf, 2010/12/06