[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 0/7] Cleanup qemu-img code
From: |
Jes . Sorensen |
Subject: |
[Qemu-devel] [PATCH v3 0/7] Cleanup qemu-img code |
Date: |
Mon, 6 Dec 2010 15:25:33 +0100 |
From: Jes Sorensen <address@hidden>
Hi,
These patches applies a number of cleanups to qemu-img.c as well as a
minor bug in qemu-malloc.c.
The handling of block help printing is moved to shared code, which
allows the "?" detection to happen early in the parsing, instead of
half way down img_create() and img_convert(). I would like to see this
happen as I would like to pull some of the code out of img_create()
and into block.c so it can be shared with qemu and qemu-img.
In addition there is a couple of patches to clean up the error
handling in qemu-img.c and make it more consistent.
The formatting patch is solely because the last patch wanted to
change code next to the badly formatted code, and I didn't want to
pollute the patch with the formatting fixed.
The seventh patch fixes qemu-img to exit on detection of unknown
options instead of continuing with a potentially wrong set of
arguments.
v3 applies a number of changes discussed on irc and email. This is the
grow to seven from three patches series.
Cheers,
Jes
Jes Sorensen (7):
Add missing tracing to qemu_mallocz()
Use qemu_mallocz() instead of calloc() in img_convert()
img_convert(): Only try to free bs[] entries if bs is valid.
Make error handling more consistent in img_create() and img_resize()
Consolidate printing of block driver options
Fix formatting and missing braces in qemu-img.c
Fail if detecting an unknown option
qemu-img.c | 162 +++++++++++++++++++++++++++++++++++++++-----------------
qemu-malloc.c | 5 ++-
2 files changed, 117 insertions(+), 50 deletions(-)
--
1.7.3.2
- [Qemu-devel] [PATCH v3 0/7] Cleanup qemu-img code,
Jes . Sorensen <=