[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC][PATCH 05/10] virtagent: add getfile RPC
From: |
Michael Roth |
Subject: |
[Qemu-devel] [RFC][PATCH 05/10] virtagent: add getfile RPC |
Date: |
Fri, 22 Oct 2010 13:46:00 -0500 |
Add RPC to retrieve a guest file. A size limit of some sort will
eventually be needed else we can block the monitor for arbitrarily long
periods of time. This interface is intended for smaller reads like
peeking at logs and /proc and such.
Signed-off-by: Michael Roth <address@hidden>
---
virtagent-daemon.c | 53 ++++++++++++++++++++++++++++++++++++++++++++++++++++
1 files changed, 53 insertions(+), 0 deletions(-)
diff --git a/virtagent-daemon.c b/virtagent-daemon.c
index 998b025..fad0f64 100644
--- a/virtagent-daemon.c
+++ b/virtagent-daemon.c
@@ -21,6 +21,57 @@
#include "virtagent-daemon.h"
#include "virtagent-common.h"
+/* RPC functions common to guest/host daemons */
+
+static xmlrpc_value *getfile(xmlrpc_env *env,
+ xmlrpc_value *param,
+ void *user_data)
+{
+ const char *path;
+ char *file_contents = NULL;
+ char buf[VA_FILEBUF_LEN];
+ int fd, ret, count = 0;
+ xmlrpc_value *result = NULL;
+
+ /* parse argument array */
+ xmlrpc_decompose_value(env, param, "(s)", &path);
+ if (env->fault_occurred) {
+ return NULL;
+ }
+
+ fd = open(path, O_RDONLY);
+ if (fd == -1) {
+ LOG("open failed: %s", strerror(errno));
+ xmlrpc_faultf(env, "open failed: %s", strerror(errno));
+ return NULL;
+ }
+
+ while ((ret = read(fd, buf, VA_FILEBUF_LEN)) > 0) {
+ file_contents = qemu_realloc(file_contents, count + VA_FILEBUF_LEN);
+ memcpy(file_contents + count, buf, ret);
+ count += ret;
+ if (count > VA_GETFILE_MAX) {
+ xmlrpc_faultf(env, "max file size (%d bytes) exceeded",
+ VA_GETFILE_MAX);
+ goto EXIT_CLOSE_BAD;
+ }
+ }
+ if (ret == -1) {
+ LOG("read failed: %s", strerror(errno));
+ xmlrpc_faultf(env, "read failed: %s", strerror(errno));
+ goto EXIT_CLOSE_BAD;
+ }
+
+ result = xmlrpc_build_value(env, "6", file_contents, count);
+
+EXIT_CLOSE_BAD:
+ if (file_contents) {
+ qemu_free(file_contents);
+ }
+ close(fd);
+ return result;
+}
+
static int va_accept(int listen_fd) {
struct sockaddr_in saddr;
struct sockaddr *addr;
@@ -48,6 +99,8 @@ typedef struct RPCFunction {
} RPCFunction;
static RPCFunction guest_functions[] = {
+ { .func = getfile,
+ .func_name = "getfile" },
{ NULL, NULL }
};
static RPCFunction host_functions[] = {
--
1.7.0.4
[Qemu-devel] [RFC][PATCH 02/10] virtagent: base definitions for host/guest RPC daemon, Michael Roth, 2010/10/22
[Qemu-devel] [RFC][PATCH 03/10] virtagent: qemu-vp, integrate virtagent daemon, Michael Roth, 2010/10/22
[Qemu-devel] [RFC][PATCH 04/10] virtagent: base RPC client definitions, Michael Roth, 2010/10/22
[Qemu-devel] [RFC][PATCH 06/10] virtagent: add agent_viewfile command, Michael Roth, 2010/10/22
[Qemu-devel] [RFC][PATCH 05/10] virtagent: add getfile RPC,
Michael Roth <=
[Qemu-devel] [RFC][PATCH 07/10] virtagent: add getdmesg RPC, Michael Roth, 2010/10/22
[Qemu-devel] [RFC][PATCH 08/10] virtagent: add agent_viewdmesg command, Michael Roth, 2010/10/22
[Qemu-devel] [RFC][PATCH 09/10] virtagent: Makefile/configure changes to build virtagent bits, Michael Roth, 2010/10/22
[Qemu-devel] [RFC][PATCH 10/10] virtproxy: add compat defs for linking against vl.c, Michael Roth, 2010/10/22
[Qemu-devel] Re: [RFC][PATCH 00/10] virtagent: host/guest RPC communication agent, Andrew Beekhof, 2010/10/23
[Qemu-devel] Re: [RFC][PATCH 00/10] virtagent: host/guest RPC communication agent, Andrew Beekhof, 2010/10/25