[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC][PATCH 01/10] virtagent: add common rpc transport
From: |
malc |
Subject: |
Re: [Qemu-devel] [RFC][PATCH 01/10] virtagent: add common rpc transport defs |
Date: |
Tue, 26 Oct 2010 01:54:38 +0400 (MSD) |
User-agent: |
Alpine 2.00 (LNX 1167 2008-08-23) |
On Mon, 25 Oct 2010, Anthony Liguori wrote:
> On 10/22/2010 01:45 PM, Michael Roth wrote:
> > Common code for sending/recieving RPCs via http over virtproxy channel.
> > Eventually these will all be switched to asynchronous handlers to avoid
> > deadlocks between qemu and the guest. For now we can usually get away with
> > just doing asynchronous reads for http/RPC responses if we don't send
> > large RPC requests to the guest (since these will likely get buffered
> > rather than block or cause spinning on writes).
[..snip..]
>
> expressions need spaces. IOW, i=0; i<len; ++i should be i = 0; i < len; i++.
>
> Avoid C++ isms like ++i.
Why?
[..snip..]
--
mailto:address@hidden
[Qemu-devel] [RFC][PATCH 02/10] virtagent: base definitions for host/guest RPC daemon, Michael Roth, 2010/10/22
[Qemu-devel] [RFC][PATCH 03/10] virtagent: qemu-vp, integrate virtagent daemon, Michael Roth, 2010/10/22
[Qemu-devel] [RFC][PATCH 04/10] virtagent: base RPC client definitions, Michael Roth, 2010/10/22
[Qemu-devel] [RFC][PATCH 06/10] virtagent: add agent_viewfile command, Michael Roth, 2010/10/22
[Qemu-devel] [RFC][PATCH 05/10] virtagent: add getfile RPC, Michael Roth, 2010/10/22
[Qemu-devel] [RFC][PATCH 07/10] virtagent: add getdmesg RPC, Michael Roth, 2010/10/22
[Qemu-devel] [RFC][PATCH 08/10] virtagent: add agent_viewdmesg command, Michael Roth, 2010/10/22