qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 1/3] qemu-kvm: Invert svm-flag setting logic


From: Roedel, Joerg
Subject: Re: [Qemu-devel] [PATCH 1/3] qemu-kvm: Invert svm-flag setting logic
Date: Tue, 7 Sep 2010 16:12:17 +0200
User-agent: Mutt/1.5.20 (2009-06-14)

On Tue, Sep 07, 2010 at 09:51:33AM -0400, Avi Kivity wrote:
>   On 09/07/2010 03:23 PM, Alexander Graf wrote:
> >
> > I think we should get rid of kvm_nested and -enable-nesting. Instead, we 
> > should enable the SVM bit in the "host" and "qemu64" cpu types, but not in 
> > "kvm64". This way users are safe to not use nested svm, but can choose to 
> > do so if they like.
> >
> > Also, it should be possible to do something like -cpu kvm64,flags=+svm. 
> > Without having to mess with -enable-nesting.
> 
> I agree, -enable-nesting is redundant with -cpu ,+svm.

This patchset makes -enable-nesting pratically a synonym for -cpu ,+svm.
So we can safely remove -enable-nesting in the future.

        Joerg

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo, Andrew Bowd
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632




reply via email to

[Prev in Thread] Current Thread [Next in Thread]