Re: [Qemu-devel] [PATCH 1/3] qemu-kvm: Invert svm-flag setting logic

[Alexander Graf]

On 07.09.2010, at 16:12, Roedel, Joerg wrote:

> On Tue, Sep 07, 2010 at 09:51:33AM -0400, Avi Kivity wrote:
>>  On 09/07/2010 03:23 PM, Alexander Graf wrote:
>>> 
>>> I think we should get rid of kvm_nested and -enable-nesting. Instead, we 
>>> should enable the SVM bit in the "host" and "qemu64" cpu types, but not in 
>>> "kvm64". This way users are safe to not use nested svm, but can choose to 
>>> do so if they like.
>>> 
>>> Also, it should be possible to do something like -cpu kvm64,flags=+svm. 
>>> Without having to mess with -enable-nesting.
>> 
>> I agree, -enable-nesting is redundant with -cpu ,+svm.
> 
> This patchset makes -enable-nesting pratically a synonym for -cpu ,+svm.
> So we can safely remove -enable-nesting in the future.

Why not just not introduce it? :) It's always hard to get rid of legacy.


Alex