[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] scsi-generic: don't report negative length to t
Re: [Qemu-devel] [PATCH] scsi-generic: don't report negative length to the SCSI adapter
Thu, 02 Sep 2010 18:17:52 +0200
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:18.104.22.168) Gecko/20100720 Fedora/3.0.6-1.fc12 Mnenhy/0.8.3 Thunderbird/3.0.6
Am 02.09.2010 16:32, schrieb ext Kevin Wolf:
Can we add a comment why len can become< 0 and that this is a
workaround for buggy drivers? It's in your commit message, but I prefer
this kind of things to be explained in the code.
Yes I will do that, if we decide to apply this patch (see below).
Also, are we sure that broken drivers always return negative numbers
when their result is wrong, or can we still get incorrect results?
Obviously there are currently no additional problems with wrong 'resid'
values. I found the problem with an older IET version (1.4.18)
which was the last one available from rpmfusion (kmod-iscsitarget,
iscsitarget, built for kernel 22.214.171.124). After that I switched
to STGT which is part of Fedora (scsi-target-utils). I don't know
how the current IET (126.96.36.199) behaves.
If the 'resid' is not reported correctly, there is no way to calculate
the correct received data length without analyzing the content of the
SCSI data. Negative length only occurred if the allocation length in
the MODE SENSE command was to small. But negative length confuses the
I propose to skip this patch as long as there are no news about IET.
Sorry for the confusion. The patch was still in my queue since March.