[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH] scsi-generic: don't report negative length to the S
From: |
Bernhard Kohl |
Subject: |
[Qemu-devel] [PATCH] scsi-generic: don't report negative length to the SCSI adapter |
Date: |
Thu, 2 Sep 2010 15:27:32 +0200 |
Some drivers report an incorrect number for 'resid'. I found that for
MODE_SENSE(6) on an IET iSCSI device. This device reports the
available mode data length minus actually transferred length.
This is already a known problem:
http://tldp.org/HOWTO/SCSI-Generic-HOWTO/x356.html
Signed-off-by: Bernhard Kohl <address@hidden>
---
hw/scsi-generic.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c
index 9538027..836678c 100644
--- a/hw/scsi-generic.c
+++ b/hw/scsi-generic.c
@@ -169,7 +169,11 @@ static void scsi_read_complete(void * opaque, int ret)
return;
}
len = r->io_header.dxfer_len - r->io_header.resid;
- DPRINTF("Data ready tag=0x%x len=%d\n", r->req.tag, len);
+ if (len < 0) {
+ len = r->io_header.dxfer_len;
+ }
+ DPRINTF("Data ready tag=0x%x len=%d dxfer_len=%d resid=%d\n",
+ r->req.tag, len, r->io_header.dxfer_len, r->io_header.resid);
r->len = -1;
r->req.bus->complete(r->req.bus, SCSI_REASON_DATA, r->req.tag, len);
--
1.7.2.2
- [Qemu-devel] [PATCH] scsi-generic: don't report negative length to the SCSI adapter,
Bernhard Kohl <=