qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] Re: [PATCH v3 2/3] qerror: Add a new MACHINE_STOPPED er


From: Anthony Liguori
Subject: Re: [Qemu-devel] Re: [PATCH v3 2/3] qerror: Add a new MACHINE_STOPPED error message
Date: Mon, 30 Aug 2010 08:06:12 -0500
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.11) Gecko/20100713 Lightning/1.0b1 Thunderbird/3.0.6

On 08/30/2010 03:30 AM, Markus Armbruster wrote:
Amit Shah<address@hidden>  writes:

On (Fri) Aug 27 2010 [07:39:37], Anthony Liguori wrote:
NACK. It has always been allowed&   valid to call query-balloon
to get the current balloon level. We must not throw an error
just because the recently added mem stats can't be refreshed.
I think that's a fair comment but why even bother fixing the
command.  Let's introduce a new command that just gets a single
piece of information instead of having a command return lots of
information.
Instead, let's have query-balloon do the same thing as it did in 0.12
and add a new command for 0.13 (query-balloon-stats) that does the stats
with timeout?

That way we won't have regressions from 0.12 and have the new behaviour
only for 0.13, which we can say is 'experimental'.
Sounds sensible to me.  Not too late for fixing 0.13?  Anthony?

No new commands for 0.13. I think the only option is to revert the query-balloon behavior. A new command is too risky as -rc1 is imminent.

Regards,

Anthony Liguori



reply via email to

[Prev in Thread] Current Thread [Next in Thread]