[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules
From: |
Jes Sorensen |
Subject: |
Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules |
Date: |
Thu, 19 Aug 2010 09:58:14 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Thunderbird/3.0.5 |
On 08/18/10 18:46, Avi Kivity wrote:
> On 08/17/2010 10:15 PM, Jes Sorensen wrote:
>>
>>> I strongly disagree. The use of "bool", even if you ignore stdbool.h
>>> and do "typedef int bool", is valuable documentation in the code.
>> I guess we have to agree to disagree then. IMHO it just masks the real
>> type and you end up with cases where people pass it back and forth
>> randomly.
>
> In C99, bool is a real type.
Kinda real, I would qualify it more as a pseudo type. It doesn't map to
any register size or even instruction actions. Most processors, at least
the ones I have programmed, tend to treat it as zero == false,
everything else == true. For structure packing it's ugly.
Jes
- Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules, (continued)
- Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules, Blue Swirl, 2010/08/17
- Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules, malc, 2010/08/17
- Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules, Jes Sorensen, 2010/08/17
- Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules, malc, 2010/08/17
- Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules, Jes Sorensen, 2010/08/17
- Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules, Anthony Liguori, 2010/08/17
- Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules, malc, 2010/08/17
Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules, Richard Henderson, 2010/08/17
- Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules, Jes Sorensen, 2010/08/17
- Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules, Avi Kivity, 2010/08/18
- Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules,
Jes Sorensen <=
- Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules, Avi Kivity, 2010/08/19
- Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules, Jes Sorensen, 2010/08/19
- Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules, Avi Kivity, 2010/08/19
- Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules, malc, 2010/08/19
- Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules, Avi Kivity, 2010/08/19
[Qemu-devel] Re: [PATCH 2/5] CODING_STYLE: add C type rules, Paolo Bonzini, 2010/08/18
[Qemu-devel] Re: [PATCH 2/5] CODING_STYLE: add C type rules, Jes Sorensen, 2010/08/18
Re: [Qemu-devel] Re: [PATCH 2/5] CODING_STYLE: add C type rules, Kevin Wolf, 2010/08/18
Re: [Qemu-devel] Re: [PATCH 2/5] CODING_STYLE: add C type rules, Paolo Bonzini, 2010/08/18
Re: [Qemu-devel] Re: [PATCH 2/5] CODING_STYLE: add C type rules, Avi Kivity, 2010/08/18