[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 2/5] CODING_STYLE: add C type rules
From: |
Jes Sorensen |
Subject: |
[Qemu-devel] Re: [PATCH 2/5] CODING_STYLE: add C type rules |
Date: |
Wed, 18 Aug 2010 10:58:26 +0200 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.10) Gecko/20100621 Fedora/3.0.5-1.fc13 Lightning/1.0b2pre Thunderbird/3.0.5 |
On 08/18/10 10:35, Paolo Bonzini wrote:
> On 08/17/2010 08:39 PM, Richard Henderson wrote:
>>> I'd strongly discourage the use of bool in any code.
>>
>> I strongly disagree. The use of "bool", even if you ignore stdbool.h
>> and do "typedef int bool", is valuable documentation in the code.
>
> I think "bool" is fine, but it should be either stdbool.h or a typedef.
> Using stdbool.h only when it is present is going to introduce bugs the
> day someone relies on the magic properties of the C99 bool.
This is exactly the problem, it doesn't buy us anything, except for
#ifdef chaos. We're better off sticking to int, then we know what we
have and avoiding this mess.
Jes
- Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules, (continued)
- Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules, Richard Henderson, 2010/08/17
- Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules, Jes Sorensen, 2010/08/17
- Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules, Avi Kivity, 2010/08/18
- Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules, Jes Sorensen, 2010/08/19
- Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules, Avi Kivity, 2010/08/19
- Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules, Jes Sorensen, 2010/08/19
- Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules, Avi Kivity, 2010/08/19
- Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules, malc, 2010/08/19
- Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules, Avi Kivity, 2010/08/19
- [Qemu-devel] Re: [PATCH 2/5] CODING_STYLE: add C type rules, Paolo Bonzini, 2010/08/18
- [Qemu-devel] Re: [PATCH 2/5] CODING_STYLE: add C type rules,
Jes Sorensen <=
- Re: [Qemu-devel] Re: [PATCH 2/5] CODING_STYLE: add C type rules, Kevin Wolf, 2010/08/18
- Re: [Qemu-devel] Re: [PATCH 2/5] CODING_STYLE: add C type rules, Paolo Bonzini, 2010/08/18
- Re: [Qemu-devel] Re: [PATCH 2/5] CODING_STYLE: add C type rules, Avi Kivity, 2010/08/18
- Re: [Qemu-devel] Re: [PATCH 2/5] CODING_STYLE: add C type rules, Paolo Bonzini, 2010/08/19
- Re: [Qemu-devel] Re: [PATCH 2/5] CODING_STYLE: add C type rules, Avi Kivity, 2010/08/19
Re: [Qemu-devel] [PATCH 2/5] CODING_STYLE: add C type rules, Avi Kivity, 2010/08/18