[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 14/35] tcg-s390: Rearrange register allocation o
From: |
Aurelien Jarno |
Subject: |
Re: [Qemu-devel] [PATCH 14/35] tcg-s390: Rearrange register allocation order. |
Date: |
Thu, 10 Jun 2010 12:26:30 +0200 |
User-agent: |
Mutt/1.5.20 (2009-06-14) |
On Fri, Jun 04, 2010 at 12:14:22PM -0700, Richard Henderson wrote:
> Try to avoid conflicting with the outgoing function call arguments.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
> tcg/s390/tcg-target.c | 23 +++++++++++++----------
> 1 files changed, 13 insertions(+), 10 deletions(-)
This patch looks fine.
> diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c
> index 95ea3c8..3944cb1 100644
> --- a/tcg/s390/tcg-target.c
> +++ b/tcg/s390/tcg-target.c
> @@ -149,22 +149,25 @@ static const char * const
> tcg_target_reg_names[TCG_TARGET_NB_REGS] = {
> };
> #endif
>
> +/* Since R6 is a potential argument register, choose it last of the
> + call-saved registers. Likewise prefer the call-clobbered registers
> + in reverse order to maximize the chance of avoiding the arguments. */
> static const int tcg_target_reg_alloc_order[] = {
> - TCG_REG_R6,
> - TCG_REG_R7,
> - TCG_REG_R8,
> - TCG_REG_R9,
> - TCG_REG_R10,
> - TCG_REG_R11,
> - TCG_REG_R12,
> TCG_REG_R13,
> + TCG_REG_R12,
> + TCG_REG_R11,
> + TCG_REG_R10,
> + TCG_REG_R9,
> + TCG_REG_R8,
> + TCG_REG_R7,
> + TCG_REG_R6,
> TCG_REG_R14,
> TCG_REG_R0,
> TCG_REG_R1,
> - TCG_REG_R2,
> - TCG_REG_R3,
> - TCG_REG_R4,
> TCG_REG_R5,
> + TCG_REG_R4,
> + TCG_REG_R3,
> + TCG_REG_R2,
> };
>
> static const int tcg_target_call_iarg_regs[] = {
> --
> 1.7.0.1
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
address@hidden http://www.aurel32.net
- Re: [Qemu-devel] [PATCH 09/35] s390: Disassemble some general-instruction-extension insns., (continued)
- [Qemu-devel] [PATCH 11/35] tcg-s390: Tidy unimplemented opcodes., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 10/35] tcg-s390: New TCG target, Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 12/35] tcg-s390: Define TCG_TMP0., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 13/35] tcg-s390: Tidy regset initialization; use R14 as temporary., Richard Henderson, 2010/06/04
- [Qemu-devel] [PATCH 14/35] tcg-s390: Rearrange register allocation order., Richard Henderson, 2010/06/04
- Re: [Qemu-devel] [PATCH 14/35] tcg-s390: Rearrange register allocation order.,
Aurelien Jarno <=
- [Qemu-devel] [PATCH 15/35] tcg-s390: Query instruction extensions that are installed., Richard Henderson, 2010/06/04
- Re: [Qemu-devel] [PATCH 15/35] tcg-s390: Query instruction extensions that are installed., Aurelien Jarno, 2010/06/10
- Re: [Qemu-devel] [PATCH 15/35] tcg-s390: Query instruction extensions that are installed., Richard Henderson, 2010/06/11
- Re: [Qemu-devel] [PATCH 15/35] tcg-s390: Query instruction extensions that are installed., Aurelien Jarno, 2010/06/13
- Re: [Qemu-devel] [PATCH 15/35] tcg-s390: Query instruction extensions that are installed., Richard Henderson, 2010/06/13
- Re: [Qemu-devel] [PATCH 15/35] tcg-s390: Query instruction extensions that are installed., Aurelien Jarno, 2010/06/13