[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 09/10] vmdk: share cleanup code
From: |
Juan Quintela |
Subject: |
[Qemu-devel] [PATCH 09/10] vmdk: share cleanup code |
Date: |
Wed, 3 Mar 2010 13:06:59 +0100 |
cleanup code is identical for error/success cases. Only difference
are goto labels.
Signed-off-by: Juan Quintela <address@hidden>
---
block/vmdk.c | 13 ++++---------
1 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index 819c1c9..007fca4 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -334,18 +334,13 @@ static int vmdk_snapshot_create(const char *filename,
const char *backing_file)
ret = -errno;
goto fail_gd;
}
- qemu_free(gd_buf);
- qemu_free(rgd_buf);
-
- close(p_fd);
- close(snp_fd);
- return 0;
+ ret = 0;
- fail_gd:
+fail_gd:
qemu_free(gd_buf);
- fail_rgd:
+fail_rgd:
qemu_free(rgd_buf);
- fail:
+fail:
close(p_fd);
close(snp_fd);
return ret;
--
1.6.5.2
- [Qemu-devel] [PATCH 01/10] cow: return errno instead of -1, (continued)
- [Qemu-devel] [PATCH 01/10] cow: return errno instead of -1, Juan Quintela, 2010/03/03
- [Qemu-devel] [PATCH 02/10] slirp: check system() success, Juan Quintela, 2010/03/03
- [Qemu-devel] [PATCH 03/10] qcow2: return errno instead of -1, Juan Quintela, 2010/03/03
- [Qemu-devel] [PATCH 04/10] qcow: return errno instead of -1, Juan Quintela, 2010/03/03
- [Qemu-devel] [PATCH 05/10] vmdk: return errno instead of -1, Juan Quintela, 2010/03/03
- [Qemu-devel] [PATCH 06/10] vl: exit if we are not able to write into the pipe, Juan Quintela, 2010/03/03
- [Qemu-devel] [PATCH 07/10] vmdk: make vmdk_snapshot_create return -errno, Juan Quintela, 2010/03/03
- [Qemu-devel] [PATCH 08/10] vmdk: fix double free, Juan Quintela, 2010/03/03
- [Qemu-devel] [PATCH 09/10] vmdk: share cleanup code,
Juan Quintela <=
- [Qemu-devel] [PATCH 10/10] block: print errno on error, Juan Quintela, 2010/03/03