[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] Re: [PATCH 10/10] block: print errno on error
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] Re: [PATCH 10/10] block: print errno on error |
Date: |
Wed, 03 Mar 2010 15:01:22 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.7) Gecko/20100120 Fedora/3.0.1-1.fc12 Thunderbird/3.0.1 |
Am 03.03.2010 13:07, schrieb Juan Quintela:
> Now that we changed all create calls to return errno, just print it.
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> qemu-img.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/qemu-img.c b/qemu-img.c
> index 0c9f2d4..f6c40fb 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -374,7 +374,7 @@ static int img_create(int argc, char **argv)
> } else if (ret == -EFBIG) {
> error("The image size is too large for file format '%s'", fmt);
> } else {
> - error("Error while formatting");
> + error("Error (%s) while formatting for file format '%s'",
> strerror(ret), fmt);
> }
> }
> return 0;
> @@ -687,7 +687,7 @@ static int img_convert(int argc, char **argv)
> } else if (ret == -EFBIG) {
> error("The image size is too large for file format '%s'",
> out_fmt);
> } else {
> - error("Error while formatting '%s'", out_filename);
> + error("Error (%s) while formatting file '%s'", strerror(ret),
> out_filename);
> }
> }
>
I think it should be strerror(-ret) in both cases.
Kevin
- [Qemu-devel] [PATCH 03/10] qcow2: return errno instead of -1, (continued)
- [Qemu-devel] [PATCH 03/10] qcow2: return errno instead of -1, Juan Quintela, 2010/03/03
- [Qemu-devel] [PATCH 04/10] qcow: return errno instead of -1, Juan Quintela, 2010/03/03
- [Qemu-devel] [PATCH 05/10] vmdk: return errno instead of -1, Juan Quintela, 2010/03/03
- [Qemu-devel] [PATCH 06/10] vl: exit if we are not able to write into the pipe, Juan Quintela, 2010/03/03
- [Qemu-devel] [PATCH 07/10] vmdk: make vmdk_snapshot_create return -errno, Juan Quintela, 2010/03/03
- [Qemu-devel] [PATCH 08/10] vmdk: fix double free, Juan Quintela, 2010/03/03
- [Qemu-devel] [PATCH 09/10] vmdk: share cleanup code, Juan Quintela, 2010/03/03
- [Qemu-devel] [PATCH 10/10] block: print errno on error, Juan Quintela, 2010/03/03
- [Qemu-devel] Re: [PATCH 10/10] block: print errno on error,
Kevin Wolf <=